BatBot initial testing and integration#305
Conversation
BryonLewis
changed the title
…into batbot-integration
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
Overall looks pretty good, excited to get this integration done. I had some feedback, but nothing too major.
Co-authored-by: Michael Nagler <mike.nagler@kitware.com>
|
Part of this was merging main into it. The migrations indicate that client redirect url should be port 8080 so I updated the client generation and dev environment to use port 8080. I added in my updated loadGRTS script in case sciencebase.gov goes down again during development The scripts folder is really meant to be more a development scripts folder. So I have stuff in there that is useful for testing. That's why you'll see duplicated stuff because it's easier for me to modify there instead across multiple files. That folder is what I'm using to go from the batbot spectrogram creation, to the eventual adding of contours in the next PR and then the exporting of the data required for drawing the metadata lines in the final PR. |
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
I'm going to do some functional testing. I had some follow-up questions about the dependencies though, that might be worth taking another look at.
|
Totally optional - any thoughts on maybe setting a higher zoom level at initial load? 
The vertical space doesn't seem to be used too well until increasing zoom a bit. |
|
I pushed 409f852 to update the redirect URL in one additional place. |
naglepuff
left a comment
naglepuff
left a comment
There was a problem hiding this comment.
I left one additional suggestion but that's non-blocking. Let's get this into main
2 participants
resolves #304
./scripts/batbot/./scripts/contours./batai/core/utils/batbot_metadata.pyfile to manage batbot and the resulting datagenerate_spectrogram_assetsmeant to be a drop-in replacement for the older generate_spectrogram_assets but this one may contain additional information in the future (contours + curves and knee, heel, toe points)